Feature/storybook delete addon knobs #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudforaison
requested changes
Nov 14, 2021
.storybook/preview-body.html
Outdated
| @@ -0,0 +1,7 @@ | |||
| <style> | |||
There was a problem hiding this comment.
Est ce que cette surcharge ne pourrait pas être dans le css ?
jest.config.ts
Outdated
| @@ -15,7 +15,9 @@ const config: Config.InitialOptions = { | |||
| '!packages/**/src/**/*.stories.*', | |||
| '!packages/**/src/**/*.spec.*', | |||
| '!packages/**/src/index.{js,ts}', | |||
There was a problem hiding this comment.
Est ce que cette ligne n'est pas incluse dans la nouvelle ?
There was a problem hiding this comment.
ah oui effectivement, je peux la supprimer
Comment on lines
59
to
76
| FileInputStoryRequired.args = { | ||
| label: 'Image', | ||
| name: 'placeImage', | ||
| id: 'inputuniqueid', | ||
| accept: 'image/jpeg, image/png, application/*', | ||
| helpMessage: 'Take a photo af a place', | ||
| message: '', | ||
| messageType: MessageTypes.error, | ||
| forceDisplayMessage: false, | ||
| multiple: true, | ||
| isVisible: true, | ||
| readOnly: false, | ||
| disabled: false, | ||
| classModifier: 'required', | ||
| className: '', | ||
| classNameContainerLabel: 'col-md-2', | ||
| classNameContainerInput: 'col-md-10', | ||
| }; |
There was a problem hiding this comment.
Suggested change
| FileInputStoryRequired.args = { | |
| label: 'Image', | |
| name: 'placeImage', | |
| id: 'inputuniqueid', | |
| accept: 'image/jpeg, image/png, application/*', | |
| helpMessage: 'Take a photo af a place', | |
| message: '', | |
| messageType: MessageTypes.error, | |
| forceDisplayMessage: false, | |
| multiple: true, | |
| isVisible: true, | |
| readOnly: false, | |
| disabled: false, | |
| classModifier: 'required', | |
| className: '', | |
| classNameContainerLabel: 'col-md-2', | |
| classNameContainerInput: 'col-md-10', | |
| }; | |
| FileInputStoryRequired.args = { | |
| ...FileInputStory.args , | |
| classModifier: 'required' | |
| }; |
arnaudforaison
approved these changes
Nov 16, 2021
delete-merged-branch
bot
deleted the
feature/storybook-delete-addon-knobs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#933
Description of the issue
rewrite stories and delete package addon-knobs