docs(migration): fixed a few typos and phrasings #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernard-arnaud
approved these changes
Mar 24, 2021
arnaudforaison
approved these changes
Mar 24, 2021
sisko59
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a few issues with this guide, and this is my proposition to fix them.
The sentence with the dynamic import was weird, and CRA has it by default. Since it's most people's tool, i feel it's better to highlight that, rather than throwing a generic "make sure your tool does the job"
Still not sure what this was meant to say, especially the "viewvalue and in the field" part. But at least the sence feels less awkward to read in my opinion.