Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Accepte un seul enfant comm tab #858

Merged
merged 1 commit into from
Mar 2, 2021
Merged

[Tabs] Accepte un seul enfant comm tab #858

merged 1 commit into from
Mar 2, 2021

Conversation

arnaudforaison
Copy link
Contributor

Fix #791

Modifications

  • les tests ont été déplacés dans le dossier tests
  • les tests utilisent testing library
  • le type de children de TabStateless est devenu un type permettant d'avoir un ou plusieurs enfants

@SamuelHsn SamuelHsn self-requested a review February 25, 2021 14:03
@arnaudforaison arnaudforaison merged commit fbcc66e into AxaFrance:master Mar 2, 2021
arnaudforaison added a commit that referenced this pull request Mar 2, 2021
@arnaudforaison
fix(tabs): accept only one child (#858)
321cc8e
@arnaudforaison arnaudforaison deleted the tabs-only-one-fix branch March 11, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmeunier johnmeunier johnmeunier left review comments

@jforatier jforatier jforatier approved these changes

@sisko59 sisko59 sisko59 approved these changes

@SamuelHsn SamuelHsn SamuelHsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Tabs component can't accept only one Tab children
5 participants
@arnaudforaison @jforatier @sisko59 @johnmeunier @SamuelHsn