Update react-dropzone dependency #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job. I think otherProps is necessary but I'll be review when this component will be migrated to TS. |
Because I don't see what kind of others props can be passed for an input file ? |
|
Others props can be all html input attributes as aria, id, ... |
johnmeunier
previously approved these changes
Dec 7, 2020
vharny
force-pushed
the
feature/update-react-dropzone
branch
from
528d352 to
ae57eee
Compare
|
SonarCloud Quality Gate failed. |
J'ai push ma modif avec le preview dans le onChange :) |
arnaudforaison
approved these changes
Dec 11, 2020
johnmeunier
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #796
Description
I've updated the react-dropzone dependency for the FileInput component.
The update had an impact on the component so I did a little refacto.
Question
I have a question about the ...otherProps, are they really necessary ? And if so, what are they used for in the case of this component?