Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(help): add tests #800

Merged
merged 1 commit into from
Nov 12, 2020
Merged

test(help): add tests #800

merged 1 commit into from
Nov 12, 2020

Conversation

xballoy
Copy link
Contributor

@xballoy xballoy commented Nov 9, 2020 •
edited
Loading

Adding functional tests using RTL on help package.

There's a strange behavior when using Help.container when using a classModifier. Because the classModifier from the container (HOC) is passed to the child we have a "double" class modifier. See this snapshot.
The Help.container wasn't either used or exposed so I removed it.

@xballoy xballoy requested a review from johnmeunier November 9, 2020 12:57
@xballoy xballoy marked this pull request as draft November 9, 2020 14:08
@xballoy xballoy force-pushed the feature/testHelp branch 2 times, most recently from d8b95e9 to bea170b Compare November 9, 2020 14:49
@xballoy xballoy marked this pull request as ready for review November 9, 2020 14:49
youf-olivier
youf-olivier previously approved these changes Nov 9, 2020
View reviewed changes
@xballoy xballoy requested a review from youf-olivier November 10, 2020 07:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@xballoy xballoy changed the title test(help): add unit test using RTL test(help): add tests Nov 10, 2020
@xballoy xballoy mentioned this pull request Nov 10, 2020
Open
@mergify mergify bot merged commit 8342537 into master Nov 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/testHelp branch November 12, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudforaison arnaudforaison arnaudforaison approved these changes

@youf-olivier youf-olivier youf-olivier approved these changes

@samuel-gomez-axa samuel-gomez-axa Awaiting requested review from samuel-gomez-axa

@johnmeunier johnmeunier Awaiting requested review from johnmeunier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xballoy @arnaudforaison @johnmeunier @youf-olivier