Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: change version of react peerDependency #798

Merged
merged 4 commits into from
Nov 13, 2020
Merged

build: change version of react peerDependency #798

merged 4 commits into from
Nov 13, 2020

Conversation

xballoy
Copy link
Contributor

@xballoy xballoy commented Nov 6, 2020 •
edited
Loading

When installing react-toolkit in a real project we have this warning on all dependencies:

npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @axa-fr/[email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.

That's because we "force" the version of react in the peerDependencies to an exact version (16.8.0) while it's working with newer React version.

@xballoy xballoy added the dependencies Pull requests that update a dependency file label Nov 6, 2020
arnaudforaison
arnaudforaison previously approved these changes Nov 6, 2020
View reviewed changes
@xballoy xballoy force-pushed the feature/reactPeerDependencies branch from b7ffb6e to a037404 Compare November 6, 2020 08:25
johnmeunier
johnmeunier previously approved these changes Nov 6, 2020
View reviewed changes
@xballoy xballoy force-pushed the feature/reactPeerDependencies branch from a037404 to b607ca7 Compare November 6, 2020 10:33
@xballoy xballoy requested a review from johnmeunier November 6, 2020 10:34
arnaudforaison
arnaudforaison previously approved these changes Nov 6, 2020
View reviewed changes
youf-olivier
youf-olivier previously approved these changes Nov 9, 2020
View reviewed changes
@xballoy xballoy dismissed stale reviews from youf-olivier and arnaudforaison via 9e67559 November 9, 2020 15:01
@xballoy xballoy force-pushed the feature/reactPeerDependencies branch from 9de46cb to 9e67559 Compare November 9, 2020 15:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mergify mergify bot merged commit 590dba9 into master Nov 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/reactPeerDependencies branch November 13, 2020 13:43
@arnaudforaison arnaudforaison mentioned this pull request Feb 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudforaison arnaudforaison arnaudforaison approved these changes

@johnmeunier johnmeunier johnmeunier approved these changes

@youf-olivier youf-olivier youf-olivier approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xballoy @arnaudforaison @johnmeunier @youf-olivier