Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix tslint error #730

Merged
merged 1 commit into from
Oct 19, 2020
Merged

style: fix tslint error #730

merged 1 commit into from
Oct 19, 2020

Conversation

xballoy
Copy link
Contributor

@xballoy xballoy commented Oct 19, 2020

Fixes Tslint warnings and errors.

Resolves CI errors on #728

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@xballoy
Copy link
Contributor Author

xballoy commented Oct 19, 2020

The quality gate is failing on coverage on new code but there is no new code...

Copy link
Contributor

@arnaudforaison arnaudforaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudforaison arnaudforaison merged commit cce4a19 into master Oct 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/eslint branch October 19, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants