Migrate collapse package to Typescript #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaume-chervet
previously approved these changes
Jul 20, 2020
romuleald
suggested changes
Sep 2, 2020
arnaudforaison
dismissed stale reviews from guillaume-chervet and xballoy
via
4388fc1
arnaudforaison
force-pushed
the
feature/migrate-collapse-ts
branch
from
af27f1d to
4388fc1
Compare
|
Need some reviewers |
xballoy
reviewed
Oct 12, 2020
|
|
||
| describe('Accordion', () => { | ||
| it('handleToggle should return correct value', () => { | ||
| let oldCollapses = [false]; |
xballoy
approved these changes
Oct 12, 2020
bernard-arnaud
approved these changes
Oct 16, 2020
romuleald
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
To have all toolkit's packages written in Typescript, this PR migrate collapse package
Important