fix(accessibility): add attribute required based on classModifier #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWeb
commented
Jul 31, 2023
MartinWeb
commented
Jul 31, 2023
JLou
previously approved these changes
Sep 5, 2023
samuel-gomez-axa
previously approved these changes
Sep 5, 2023
MartinWeb
dismissed stale reviews from samuel-gomez-axa and JLou
via
d77682e
MartinWeb
force-pushed
the
fix/requiredAttribute
branch
from
f7031f1 to
d77682e
Compare
JLou
previously approved these changes
Sep 7, 2023
MartinWeb
force-pushed
the
fix/requiredAttribute
branch
from
d77682e to
8a50ed4
Compare
samuel-gomez-axa
previously approved these changes
Sep 8, 2023
|
à retester sur site, en local le aria-required du SelectMulti n'est plus présent |
JLou
previously approved these changes
Sep 11, 2023
MartinWeb
force-pushed
the
fix/requiredAttribute
branch
from
8a50ed4 to
928c0bf
Compare
MartinWeb
dismissed stale reviews from samuel-gomez-axa and JLou
via
19842a5
MartinWeb
force-pushed
the
fix/requiredAttribute
branch
from
928c0bf to
19842a5
Compare
MartinWeb
force-pushed
the
fix/requiredAttribute
branch
from
19842a5 to
b08a551
Compare
samuel-gomez-axa
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#1044
Person(s) for reviewing proposed changes
@arnaudforaison @samuel-gomez @buddyvegas