Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hoc): rewrite and clean some HOCs #1007

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Conversation

samuel-gomez
Copy link
Contributor

@samuel-gomez samuel-gomez commented Jan 26, 2023

Related issue

fix #1006

Description of the issue

  • Suppression des HOCs (withProps, withClassDefault, identity.hoc, withClassModifier, withClickId )
  • Suppression du compose
  • Uniformisation de l'utilisation du getComponentClassName
  • Remplacement du HOC withClickId par un helper getClickId

Person(s) for reviewing proposed changes

@korger-johan @arnaudforaison @MartinWeb

Important

Before creating a pull request run unit tests

$ npm test

# watch for changes
$ npm test -- --watch

# For a specific file (e.g., in packages/context/__tests__/command.test.js)
$ npm test -- --watch packages/action

@MartinWeb
Copy link
Contributor

@samuel-gomez est-ce que l'on ne mettrait pas ce genre de modifications dans la possible future v3 qui a été discuté en COP dernièrement ?
Cela touche également à une refacto des HOC.

@samuel-gomez
Copy link
Contributor Author

Merci pour ton retour @MartinWeb
Cette PR n'implique pas de breaking change, la V3 devrait surtout concerner le HOC withInput qui est impactant sur tous les champs de formulaire.
On peut déjà commencer à épurer avant ;)
Sauf si vous y voyez une objection évidemment.

MartinWeb
MartinWeb previously approved these changes Jan 26, 2023
@samuel-gomez-axa samuel-gomez-axa force-pushed the feature/refactor-hoc branch 2 times, most recently from 771d59c to 62d5285 Compare January 26, 2023 22:54
@samuel-gomez samuel-gomez merged commit 8d42bf5 into master Jan 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the feature/refactor-hoc branch January 30, 2023 13:18
@MartinWeb MartinWeb added this to the v2.1.0 milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HOC] rewrite and delete some HOCs
4 participants