Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Header): implement header agent component #179

Merged
merged 8 commits into from
May 28, 2024
Merged

feat(Header): implement header agent component #179

merged 8 commits into from
May 28, 2024

Conversation

Nourelayne
Copy link
Contributor

@Nourelayne Nourelayne commented Feb 29, 2024 •
edited
Loading

Cette PR concerne l'issue numéro 32:

  • Implémentation du composant Header Agent
  • Implémentation du composant Name
  • Implémentation du composant Infos
  • Implémentation du composant Title
  • Implémentation du composant User

@Nourelayne Nourelayne force-pushed the feature/header-agent-component branch 4 times, most recently from 970b859 to b636ed1 Compare March 1, 2024 11:39
GuillaumeKESTEMAN
GuillaumeKESTEMAN reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@GuillaumeKESTEMAN GuillaumeKESTEMAN left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il manque aussi les déclarations de tes composants dans agents.ts (dans css/src et react/src).

@Nourelayne Nourelayne force-pushed the feature/header-agent-component branch 2 times, most recently from 2ea4748 to 691e51e Compare March 4, 2024 10:47
GuillaumeKESTEMAN
GuillaumeKESTEMAN reviewed Mar 4, 2024
View reviewed changes
packages/react/src/agent.ts Outdated
Comment on lines 35 to 57
Infos,
Name,
NavBar,
NavBarItem,
Title as TitleHeader,
ToggleButton,
User,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dans react-toolkit les composants portent ces noms ?
Ne serait-ce pas mieux de préciser Header dans le nom pour préciser que c'est un sous-composant de Header ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense qu'il y a un point aujourd'hui à 15h30, on peut en discuter avec les autres ça sera mieux :)

@Nourelayne Nourelayne force-pushed the feature/header-agent-component branch from 691e51e to 2f390fb Compare March 6, 2024 22:17
@fffan64 fffan64 added the agent-slash Component for the agent theme label Mar 8, 2024
@Nourelayne Nourelayne force-pushed the feature/header-agent-component branch 2 times, most recently from 955380c to 6313c60 Compare March 13, 2024 15:47
GuillaumeKESTEMAN
GuillaumeKESTEMAN reviewed Mar 13, 2024
View reviewed changes
packages/react/src/Header/NavBar/NavBar.stories.tsx Outdated
Comment on lines 4 to 5
import "@axa-fr/design-system-css/dist/Header/NavBar/NavBar.scss";
import "@axa-fr/design-system-css/dist/Header/Drawer/Drawer.scss";

This comment was marked as resolved.

Sign in to view

@Nourelayne Nourelayne force-pushed the feature/header-agent-component branch from 6313c60 to 2c5f0eb Compare March 18, 2024 13:47
@Nourelayne Nourelayne force-pushed the feature/header-agent-component branch from 2c5f0eb to bbd7989 Compare March 19, 2024 08:47
@Nourelayne Nourelayne force-pushed the feature/header-agent-component branch 3 times, most recently from 5d6f945 to a227187 Compare March 19, 2024 14:05
@Nourelayne Nourelayne requested review from JLou and samuel-gomez March 21, 2024 09:15
@GuillaumeKESTEMAN GuillaumeKESTEMAN marked this pull request as draft March 22, 2024 11:23
@GuillaumeKESTEMAN GuillaumeKESTEMAN force-pushed the feature/header-agent-component branch from a227187 to af60e92 Compare March 22, 2024 14:47
This was linked to issues Mar 22, 2024
Component Header #32
Closed
Component Titlebar #33
Closed
@MartinWeb
Copy link
Contributor

Pensez à intégrer le mode sticky par défaut du header
AxaFrance/react-toolkit#1113

@GuillaumeKESTEMAN
Copy link
Contributor

Pensez à intégrer le mode sticky par défaut du header AxaFrance/react-toolkit#1113

Il est présent je crois, il manque juste un z-index apparemment :
https://github.com/AxaFrance/design-system/blob/feature/header-agent-component/packages/css/src/Layout/Header/Agent/TitleHeader/TitleHeader.scss#L11-L14

@Nourelayne
Copy link
Contributor Author

En effet, il manque la propriété z-index, je vais mettre à jour ma branche et l'ajouter.

@Nourelayne Nourelayne force-pushed the feature/header-agent-component branch 2 times, most recently from f63771e to 9980780 Compare April 12, 2024 09:36
@Nourelayne Nourelayne force-pushed the feature/header-agent-component branch from 9980780 to fea7033 Compare May 12, 2024 11:52
@Nourelayne Nourelayne marked this pull request as ready for review May 12, 2024 11:55
@Nourelayne Nourelayne force-pushed the feature/header-agent-component branch from fea7033 to d0ed6b4 Compare May 13, 2024 08:56
@samuel-gomez samuel-gomez merged commit 422bdfc into main May 28, 2024
1 check passed
@samuel-gomez samuel-gomez deleted the feature/header-agent-component branch May 28, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuel-gomez samuel-gomez samuel-gomez approved these changes

@GuillaumeKESTEMAN GuillaumeKESTEMAN GuillaumeKESTEMAN approved these changes

@JLou JLou Awaiting requested review from JLou

Assignees

@Nourelayne Nourelayne

Labels
agent-slash Component for the agent theme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component Titlebar Component Header
5 participants
@Nourelayne @MartinWeb @GuillaumeKESTEMAN @samuel-gomez @fffan64