Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Project Reactor #133

Merged
merged 7 commits into from
Jun 20, 2022
Merged

Support for Project Reactor #133

merged 7 commits into from
Jun 20, 2022

Conversation

ath0s
Copy link
Contributor

@ath0s ath0s commented May 27, 2022

  • Refactored ReactiveTypeHandlerPlugin to make supporting additional reactive types easier.
    • Refactored ReactiveTypeHandlerContract to not use ReactiveExecutionListener, which was removed
    • Refactored CompletableFutureTypeHandlerPlugin
    • Refactored AsyncFutureTypeHandler, using SettableFuture rather than custom AsyncFutureImpl
    • Moved AsyncFutureTypeHandlerTest to astrix-gs module
  • Reimplemented support for RxJava 1.x Single and Completable using ReactiveTypeHandlerPlugin
    • Added RxCompletableTypeHandlerPluginTest
    • Added RxSingleTypeHandlerPluginTest
  • Implemented support for Reactor types
    • Added FluxTypeHandlerPlugin and FluxTypeHandlerPluginTest
    • Added MonoTypeHandlerPlugin and MonoTypeHandlerPluginTest
    • Added AstrixContextPlugin modules for both types. Note that two separate modules are necessary, because only one instance can be bound to a plugin type per module.

ath0s added 3 commits May 27, 2022 20:22
- Refactored ReactiveTypeHandlerPlugin to make supporting additional reactive types easier.
    - Refactored ReactiveTypeHandlerContract to not use ReactiveExecutionListener, which was removed
    - Refactored CompletableFutureTypeHandlerPlugin
    - Refactored AsyncFutureTypeHandler, using SettableFuture rather than custom AsyncFutureImpl
    - Moved AsyncFutureTypeHandlerTest to astrix-gs module
- Reimplemented support for RxJava 1.x Single and Completable using ReactiveTypeHandlerPlugin
    - Added RxCompletableTypeHandlerPluginTest
    - Added RxSingleTypeHandlerPluginTest
- Implemented support for Reactor types
    - Added FluxTypeHandlerPlugin and FluxTypeHandlerPluginTest
    - Added MonoTypeHandlerPlugin and MonoTypeHandlerPluginTest
    - Added AstrixContextPlugin modules for both types. Note that two separate modules are necessary, because only one instance can be bound to a plugin type per module
@ath0s ath0s marked this pull request as draft May 27, 2022 20:12
…y stream (such as when synchronous return type is void)
@ath0s ath0s marked this pull request as ready for review May 30, 2022 11:40
@ath0s ath0s requested a review from kbs4j May 31, 2022 16:31
Copy link
Contributor

@askoog askoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change Daniel! Should make future additions easy to implement

@ath0s ath0s removed the request for review from kbs4j June 20, 2022 10:07
@ath0s ath0s merged commit 42e37bd into main Jun 20, 2022
@ath0s ath0s deleted the reactor branch June 20, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants