Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name Generator should ignore non Avalonia xaml files (Maui Hybrid) #12855

Closed
maxkatz6 opened this issue Sep 11, 2023 · 0 comments · Fixed by #13001
Closed

Name Generator should ignore non Avalonia xaml files (Maui Hybrid) #12855

maxkatz6 opened this issue Sep 11, 2023 · 0 comments · Fixed by #13001
Labels
area-analyzers bug

Comments

@maxkatz6
Copy link
Member

Describe the bug

XAML files are automatically added to the AdditionalFiles collection to be used in source generator.
But MAUI does the same for its own needs, and we have a conflict where Avalonia Name Generator tries to parse MAUI XAML files.
See AvaloniaUI/AvaloniaMauiHybrid#8

To Reproduce
Steps to reproduce the behavior:

  1. Create project with XAML files from Avalonia AND Maui.

Expected behavior

Name generator works without crashing.
@maxkatz6 maxkatz6 mentioned this issue Sep 14, 2023
Closed
maxkatz6 added a commit that referenced this issue Sep 23, 2023
@maxkatz6
Respect SourceItemGroupMetadata to fix #12855
97b0fee
@maxkatz6 maxkatz6 mentioned this issue Sep 23, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 23, 2023
@maxkatz6
Fix XAML name generator with non-Avalonia XAML files (#13001)
292d7ac 
* Fix #12841 by not putting stacktrace in the error message

* Respect SourceItemGroupMetadata to fix #12855

* Fix Generators.Sandbox
grokys pushed a commit that referenced this issue Oct 2, 2023
@maxkatz6 @grokys
Fix XAML name generator with non-Avalonia XAML files (#13001)
29bc00e 
* Fix #12841 by not putting stacktrace in the error message

* Respect SourceItemGroupMetadata to fix #12855

* Fix Generators.Sandbox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-analyzers bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix XAML name generator with non-Avalonia XAML files AvaloniaUI/Avalonia
1 participant
@maxkatz6