This repository has been archived by the owner on Feb 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
on_action can be a function (#939) #940
Merged
FredLL-Avaiga
merged 4 commits into
develop
from
feature/#939-download-on_action-as-function
Sep 29, 2023
Merged
on_action can be a function (#939) #940
FredLL-Avaiga
merged 4 commits into
develop
from
feature/#939-download-on_action-as-function
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabienLelaquais
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eaaaasy! 🙏
dinhlongviolin1
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review on new phone!
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 80.45% | 2218/2757 |
🟡 | Branches | 62.2% | 1338/2151 |
🟡 | Functions | 75% | 387/516 |
🟢 | Lines | 80.86% | 2058/2545 |
Test suite run success
317 tests passing in 35 suites.
Report generated by 🧪jest coverage report action from 377be6e
😜 |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Gui: Back-End
Related to the back-end side of Taipy GUI.
📈 Improvement
Improvement of a feature.
🟥 Priority: Critical
Must be fixed ASAP
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #939.