Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

on_action can be a function (#939) #940

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

FredLL-Avaiga
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga commented Sep 29, 2023

Addresses #939.

@FredLL-Avaiga FredLL-Avaiga added 🟥 Priority: Critical Must be fixed ASAP 📈 Improvement Improvement of a feature. Gui: Back-End Related to the back-end side of Taipy GUI. labels Sep 29, 2023
@FredLL-Avaiga FredLL-Avaiga self-assigned this Sep 29, 2023
@FredLL-Avaiga FredLL-Avaiga added the 📝Release Notes Impacts the Release Notes label Sep 29, 2023
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eaaaasy! 🙏

Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review on new phone!

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Coverage report for gui

St.
Category Percentage Covered / Total
🟢 Statements 80.45% 2218/2757
🟡 Branches 62.2% 1338/2151
🟡 Functions 75% 387/516
🟢 Lines 80.86% 2058/2545

Test suite run success

317 tests passing in 35 suites.

Report generated by 🧪jest coverage report action from 377be6e

@FabienLelaquais
Copy link
Member

First review on new phone!

😜

@github-actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
5106 4366 86% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/taipy/gui/gui.py 87% 🟢
src/taipy/gui/gui_actions.py 70% 🟢
TOTAL 78% 🟢

updated for commit: 377be6e by action🐍

@FredLL-Avaiga FredLL-Avaiga merged commit 5d58899 into develop Sep 29, 2023
@FredLL-Avaiga FredLL-Avaiga deleted the feature/#939-download-on_action-as-function branch September 29, 2023 16:13
@FabienLelaquais FabienLelaquais removed the 📝Release Notes Impacts the Release Notes label Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Gui: Back-End Related to the back-end side of Taipy GUI. 📈 Improvement Improvement of a feature. 🟥 Priority: Critical Must be fixed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants