Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

Builder API improvement (#921) #924

Merged
merged 9 commits into from
Oct 3, 2023
Merged

Builder API improvement (#921) #924

merged 9 commits into from
Oct 3, 2023

Conversation

dinhlongviolin1
Copy link
Member

@dinhlongviolin1 dinhlongviolin1 commented Sep 22, 2023 •
edited
Loading

Solve Issue #921

@github-actions
Copy link

github-actions bot commented Sep 22, 2023 •
edited
Loading

Coverage report for gui

St.❔
 Category Percentage Covered / Total
🟢 Statements 80.45% 2218/2757
🟡 Branches 62.2% 1338/2151
🟡 Functions 75% 387/516
🟢 Lines 80.86% 2058/2545

Test suite run success

317 tests passing in 35 suites.

Report generated by 🧪jest coverage report action from 335ac38

@github-actions
Copy link

github-actions bot commented Sep 22, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
5129 4388 86% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/taipy/gui/init.py 100% 🟢
src/taipy/gui/_page.py 100% 🟢
src/taipy/gui/builder/init.py 100% 🟢
src/taipy/gui/builder/page.py 100% 🟢
src/taipy/gui/extension/library.py 87% 🟢
src/taipy/gui/gui.py 87% 🟢
src/taipy/gui/page.py 91% 🟢
src/taipy/gui/server.py 87% 🟢
src/taipy/gui/utils/chart_config_builder.py 91% 🟢
TOTAL 94% 🟢

updated for commit: 335ac38 by action🐍

@dinhlongviolin1 dinhlongviolin1 requested review from FabienLelaquais and FredLL-Avaiga and removed request for FabienLelaquais September 22, 2023 08:57
@dinhlongviolin1 dinhlongviolin1 self-assigned this Sep 22, 2023
@dinhlongviolin1 dinhlongviolin1 added 📈 Improvement Improvement of a feature. Gui: Back-End Related to the back-end side of Taipy GUI. 🟧 Priority: High Stalls work on the project or its dependents 📝Release Notes Impacts the Release Notes labels Sep 22, 2023
@dinhlongviolin1 dinhlongviolin1 marked this pull request as ready for review September 22, 2023 08:58
FredLL-Avaiga
FredLL-Avaiga approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BIG changes

FabienLelaquais
FabienLelaquais approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@dinhlongviolin1 dinhlongviolin1 merged commit 0bfd34c into develop Oct 3, 2023
@dinhlongviolin1 dinhlongviolin1 deleted the feature/#921-bulder-api-improvement branch October 3, 2023 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabienLelaquais FabienLelaquais FabienLelaquais approved these changes

@FredLL-Avaiga FredLL-Avaiga FredLL-Avaiga approved these changes

Assignees

@dinhlongviolin1 dinhlongviolin1

Labels
Gui: Back-End Related to the back-end side of Taipy GUI. 📈 Improvement Improvement of a feature. 🟧 Priority: High Stalls work on the project or its dependents 📝Release Notes Impacts the Release Notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dinhlongviolin1 @FabienLelaquais @FredLL-Avaiga