Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

date range #1002

Merged
merged 13 commits into from
Nov 6, 2023
Merged

date range #1002

merged 13 commits into from
Nov 6, 2023

Conversation

FredLL-Avaiga
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga commented Nov 3, 2023

Addresses Avaiga/taipy#441

adding label to date
Github actions uses node 20 LTS
gui version 3.1.0

adding label to date
Github actions uses node 20 LTS
gui version 3.1.0
@FredLL-Avaiga FredLL-Avaiga added 🟥 Priority: Critical Must be fixed ASAP Gui: Back-End Related to the back-end side of Taipy GUI. GUI: Front-End Related to the front-end side of Taipy GUI. ✨New feature A new feature is introduced. labels Nov 3, 2023
@FredLL-Avaiga FredLL-Avaiga self-assigned this Nov 3, 2023
Copy link

github-actions bot commented Nov 3, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
5205 4492 86% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/taipy/gui/_renderers/factory.py 99% 🟢
src/taipy/gui/types.py 92% 🟢
src/taipy/gui/utils/init.py 100% 🟢
src/taipy/gui/utils/types.py 86% 🟢
TOTAL 94% 🟢

updated for commit: 79df4fc by action🐍

Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

Copy link

github-actions bot commented Nov 3, 2023

Coverage report for gui

St.
Category Percentage Covered / Total
🟢 Statements 80.85% 2293/2836
🟡 Branches 62.43% 1391/2228
🟡 Functions 75.38% 401/532
🟢 Lines 81.21% 2127/2619
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / DateRange.tsx
95.59% 86.79% 100% 95.16%
🟢
... / Dialog.tsx
80.43% 60.87% 100% 80.43%
🟡
... / TaipyRendered.tsx
66.67% 17.65% 50% 66.67%
🟡
... / index.ts
73.33% 26.67% 50% 72.73%
🟢
... / Expandable.tsx
100% 85% 100% 100%
🟢
... / PageContent.tsx
75% 100% 0% 100%
🟢
... / Pane.tsx
95.12% 73.81% 100% 94.87%
🟢
... / Part.tsx
88% 64.29% 75% 91.3%
🟡
... / Unregistered.tsx
62.5% 0% 0% 60%

Test suite run success

334 tests passing in 36 suites.

Report generated by 🧪jest coverage report action from 4996848

Copy link

github-actions bot commented Nov 3, 2023

Coverage report for gui

Branches coverage not met for global: expected >=80%, but got 62.432675044883304%

St.
Category Percentage Covered / Total
🟢 Statements
80.85% (+0.43% 🔼)
2293/2836
🟡 Branches
62.43% (+0.01% 🔼)
1391/2228
🟡 Functions
75.38% (+0.27% 🔼)
401/532
🟢 Lines
81.21% (+0.44% 🔼)
2127/2619
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Dialog.tsx
80.43% 60.87% 100% 80.43%
🟡
... / TaipyRendered.tsx
66.67% 17.65% 50% 66.67%
🟡
... / index.ts
73.33% 26.67% 50% 72.73%
🟢
... / DateRange.tsx
95.59% 86.79% 100% 95.16%
🟢
... / Expandable.tsx
100% 85% 100% 100%
🟢
... / PageContent.tsx
75% 100% 0% 100%
🟢
... / Pane.tsx
95.12% 73.81% 100% 94.87%
🟢
... / Part.tsx
88% 64.29% 75% 91.3%
🟡
... / Unregistered.tsx
62.5% 0% 0% 60%

Test suite run success

334 tests passing in 36 suites.

Report generated by 🧪jest coverage report action from 79df4fc

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, the date-or-time mode makes the 'with_time' parameter a bit confusing...
We've got planty of time to change that if needed.

@FredLL-Avaiga FredLL-Avaiga merged commit 4d4fc6c into develop Nov 6, 2023
@FredLL-Avaiga FredLL-Avaiga deleted the feature/date-range branch November 6, 2023 10:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Gui: Back-End Related to the back-end side of Taipy GUI. GUI: Front-End Related to the front-end side of Taipy GUI. ✨New feature A new feature is introduced. 🟥 Priority: Critical Must be fixed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants