Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help Center: Allow premium support with some products #99497

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Help Center: Allow premium support with some products #99497

wants to merge 2 commits into from
+65 −25

Conversation

escapemanuele
Copy link
Contributor

@escapemanuele escapemanuele commented Feb 7, 2025 •
edited
Loading

Fixes https://github.com/Automattic/dotcom-forge/issues/10413

Proposed Changes

now we have the possibility of setting an option to allow free users to talk to Happiness Engineers. Usually they would be directed to forums.

Why are these changes being made?

To provide support for users in some flows, for example in the 100-year one

Testing Instructions

  • Create a new user
  • Visit /setup/hundred-year-plan
  • Reach checkout, open the Help Center (top right link) and try to talk with an Happiness Engineer

@matticbot
Copy link
Contributor

matticbot commented Feb 7, 2025 •
edited
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-132492
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-132492&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-132492&env=a8c-for-agencies

@escapemanuele escapemanuele self-assigned this Feb 7, 2025
@escapemanuele escapemanuele marked this pull request as ready for review February 7, 2025 17:56
@escapemanuele escapemanuele requested a review from a team as a code owner February 7, 2025 17:56
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2025
@matticbot
Copy link
Contributor

matticbot commented Feb 7, 2025 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~57 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +243 B  (+0.0%)      +57 B  (+0.0%)
entry-main          +243 B  (+0.0%)      +57 B  (+0.0%)
entry-login         +243 B  (+0.0%)      +57 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~310 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
settings                   +137 B  (+0.0%)      +32 B  (+0.0%)
marketplace                +137 B  (+0.0%)      +39 B  (+0.0%)
checkout                   +137 B  (+0.0%)      +38 B  (+0.0%)
write-flow                  +81 B  (+0.0%)      +14 B  (+0.0%)
themes                      +81 B  (+0.0%)      +23 B  (+0.0%)
theme                       +81 B  (+0.0%)      +16 B  (+0.0%)
site-settings               +81 B  (+0.0%)      +14 B  (+0.0%)
site-overview               +81 B  (+0.0%)      +11 B  (+0.0%)
settings-writing            +81 B  (+0.0%)      +30 B  (+0.0%)
plans                       +81 B  (+0.0%)      +15 B  (+0.0%)
link-in-bio-tld-flow        +81 B  (+0.0%)      +14 B  (+0.0%)
hosting                     +81 B  (+0.0%)      +14 B  (+0.0%)
home                        +81 B  (+0.0%)      +16 B  (+0.0%)
gutenberg-editor            +81 B  (+0.0%)      +26 B  (+0.0%)
earn                        +81 B  (+0.0%)      +26 B  (+0.0%)
customize                   +81 B  (+0.0%)      +24 B  (+0.0%)
build-flow                  +81 B  (+0.0%)      +14 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~859 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal                +819 B  (+0.0%)     +327 B  (+0.1%)
async-load-calypso-layout-masterbar-checkout              +819 B  (+1.2%)     +333 B  (+1.3%)
async-load-automattic-help-center-stepper                 +309 B  (+0.0%)     +116 B  (+0.0%)
async-load-automattic-help-center                         +309 B  (+0.0%)     +112 B  (+0.1%)
async-load-signup-steps-theme-selection                    +81 B  (+0.0%)      +23 B  (+0.0%)
async-load-design-blocks                                   +81 B  (+0.0%)      +23 B  (+0.0%)
async-load-calypso-components-web-preview-component        +81 B  (+0.0%)      +25 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug hc-allow-premium on your sandbox.

alshakero
alshakero reviewed Feb 7, 2025
View reviewed changes
Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Simple and does the job. Left some optional comments.

Maaaybe we should reset the value when someone closes the help center?

client/layout/masterbar/checkout.tsx
@@ -54,6 +55,10 @@ const CheckoutMasterbar = ( {
const { responseCart, replaceProductsInCart } = useShoppingCart( cartKey );
const [ isModalVisible, setIsModalVisible ] = useState( false );

const isPremiumSupportEligible = responseCart.products.some( ( product ) =>
PREMIUM_SUPPORT_PRODUCT_SLUGS.includes( product.product_slug )
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this logic inside DefaultMasterbarContact to avoid prop drilling.

client/my-sites/checkout/checkout-thank-you/redesign-v2/masterbar-styled/default-contact.tsx
Comment on lines +58 to +62
export function DefaultMasterbarContact( {
allowPremiumSupport = false,
}: {
allowPremiumSupport?: boolean;
} ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you agree with the above, you don't have to change this.

packages/data-stores/src/help-center/actions.ts
@@ -193,6 +193,12 @@ export const setShowSupportDoc = function* ( link: string, postId?: number, blog
yield setIsMinimized( false );
};

export const setAllowPremiumSupport = ( allow: boolean ) =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace this action creator with a boolean in setShowHelpCenter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alshakero alshakero alshakero left review comments

Assignees

@escapemanuele escapemanuele

Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@escapemanuele @matticbot @alshakero