Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Remove unused StandAloneComparisonGrid #99490

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Feb 7, 2025

Proposed Changes

Removes the StandAloneComparisonGrid component which was never used a year after its creation in #88045.

At the same time, the issue it was created for has already been finished and closed.

Why are these changes being made?

Just cleaning up.

Testing Instructions

Verify the removed code is not in use.

@tyxla tyxla added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Components [Type] Janitorial labels Feb 7, 2025
@tyxla tyxla requested review from a team February 7, 2025 15:30
@tyxla tyxla self-assigned this Feb 7, 2025
@tyxla tyxla mentioned this pull request Feb 7, 2025
7 tasks
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/standalone-comparison-grid on your sandbox.

Copy link
Contributor

@andres-blanco andres-blanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@tyxla tyxla merged commit 524be26 into trunk Feb 10, 2025
17 of 18 checks passed
@tyxla tyxla deleted the remove/standalone-comparison-grid branch February 10, 2025 08:20
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants