Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Update several /client components to replace formatNumnber with i18n-calypso numberFormat #99156

Draft
wants to merge 1 commit into
base: update/fix-number-format-a8c-for-agencies
Choose a base branch
from

Conversation

chriskmnds
Copy link
Contributor

Part of addressing https://github.com/Automattic/i18n-issues/issues/934

Proposed Changes

WIP

Why are these changes being made?

See https://github.com/Automattic/i18n-issues/issues/934

Testing Instructions

WIP

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~400 bytes removed 📉 [gzipped])

name                            parsed_size           gzip_size
a8c-for-agencies-purchases           -969 B  (-0.1%)     -397 B  (-0.2%)
a8c-for-agencies-client              -949 B  (-0.1%)     -381 B  (-0.1%)
a8c-for-agencies-marketplace         -883 B  (-0.1%)     -334 B  (-0.1%)
subscribers                          -111 B  (-0.0%)      -28 B  (-0.0%)
jetpack-cloud-agency-dashboard        -74 B  (-0.0%)       +0 B
a8c-for-agencies-sites                -74 B  (-0.0%)       +0 B

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1194 bytes removed 📉 [gzipped])

name                                        parsed_size           gzip_size
async-load-calypso-blocks-reader-full-post      -1097 B  (-2.7%)     -412 B  (-3.5%)
async-load-design-blocks                        -1011 B  (-0.0%)     -411 B  (-0.1%)
async-load-calypso-reader-site-stream            -938 B  (-4.9%)     -371 B  (-5.8%)
async-load-calypso-reader-feed-stream            -938 B  (-4.8%)     -371 B  (-5.6%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants