-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: Update /read recent posts empty message #99132
base: add/date-limit-to-following-feed
Are you sure you want to change the base?
Reader: Update /read recent posts empty message #99132
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~326 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17220392 Some locales (Hebrew, Japanese, Spanish) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @DustyReagan for including a screenshot in the description! This is really helpful for our translators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to #98883
Proposed Changes
FollowingEmptyContent
component in both "Full post" and "Scrolling feed" views.FollowingEmptyContent
component message seen in the "Recent" "Full post" and "Scrolling feed" views. (aka /read)Full Post View
Specific sites CTA links to the full site feed if there are no results less than 60 days old.
"All" sites CTA links to the Discover page if there are no results less than 60 days old.
Scrolling Feed View
Specific sites CTA links to the full site feed if there are no results less than 60 days old.
"All" sites CTA links to the Discover page if there are no results less than 60 days old.
Why are these changes being made?
Testing Instructions
The easiest way to test this is to run this PR locally and update the Stream API so it returns no results. Like this:
Now you can view the changes on http://calypso.localhost:3000/read and confirm they match the screenshots above. The CTA buttons should be clickable and include Tracks events when clicked.
Confirm that the
FollowingEmptyContent
isn't used somewhere else where these copy changes wouldn't make sense.Pre-merge Checklist