Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Update /read recent posts empty message #99132

Open
wants to merge 1 commit into
base: add/date-limit-to-following-feed
Choose a base branch
from

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Jan 30, 2025

Related to #98883

Proposed Changes

  • Small refactor to reuse the FollowingEmptyContent component in both "Full post" and "Scrolling feed" views.
  • Updates the FollowingEmptyContent component message seen in the "Recent" "Full post" and "Scrolling feed" views. (aka /read)
  • Increased CSS top margin on the empty message.

Full Post View

Specific sites CTA links to the full site feed if there are no results less than 60 days old.

Before After
Screenshot 2025-01-30 at 4 02 11 PM Screenshot 2025-01-30 at 4 02 22 PM

"All" sites CTA links to the Discover page if there are no results less than 60 days old.

Before After
Screenshot 2025-01-30 at 4 11 16 PM Screenshot 2025-01-30 at 4 07 06 PM

Scrolling Feed View

Specific sites CTA links to the full site feed if there are no results less than 60 days old.

Before After
Screenshot 2025-01-30 at 4 19 00 PM Screenshot 2025-01-30 at 4 18 15 PM

"All" sites CTA links to the Discover page if there are no results less than 60 days old.

Before After
Screenshot 2025-01-30 at 4 14 39 PM Screenshot 2025-01-30 at 4 16 25 PM

Why are these changes being made?

Testing Instructions

The easiest way to test this is to run this PR locally and update the Stream API so it returns no results. Like this:

--- a/client/state/data-layer/wpcom/read/streams/index.js
+++ b/client/state/data-layer/wpcom/read/streams/index.js
@@ -202,7 +202,7 @@ const streamApis = {
                        // If no after param is provided, default to 60 days ago
                        if ( ! filteredExtras.after && ! filteredExtras.pageHandle?.after ) {
                                const sixtyDaysAgo = new Date();
-                               sixtyDaysAgo.setDate( sixtyDaysAgo.getDate() - 60 );
+                               sixtyDaysAgo.setDate( sixtyDaysAgo.getDate() - 0 );
                                filteredExtras.after = sixtyDaysAgo.toISOString().split( '.' )[ 0 ] + 'Z';
                        }
 
@@ -220,6 +220,7 @@ const streamApis = {
                                // 'recent' without a suffix means don't filter by feedId
                                queryParams.feed_id = feedId;
                        }
+                       queryParams.feed_id = 0;
                        return getQueryString( queryParams );
                },
        },

Now you can view the changes on http://calypso.localhost:3000/read and confirm they match the screenshots above. The CTA buttons should be clickable and include Tracks events when clicked.

Confirm that the FollowingEmptyContent isn't used somewhere else where these copy changes wouldn't make sense.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@DustyReagan DustyReagan self-assigned this Jan 30, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/recent-empty-posts-msg on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~326 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
plugins                              +1388 B  (+0.0%)     +360 B  (+0.0%)
jetpack-cloud-plugin-management      +1388 B  (+0.1%)     +360 B  (+0.1%)
home                                 +1388 B  (+0.1%)     +360 B  (+0.1%)
a8c-for-agencies-plugins             +1388 B  (+0.1%)     +360 B  (+0.1%)
reader                               +1278 B  (+0.1%)     +326 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@DustyReagan DustyReagan changed the title Reader: Update recent empty post message Reader: Update /read recent posts empty message Jan 30, 2025
@DustyReagan DustyReagan marked this pull request as ready for review January 30, 2025 22:32
@DustyReagan DustyReagan requested a review from a team as a code owner January 30, 2025 22:32
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 30, 2025
@DustyReagan DustyReagan added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jan 31, 2025
@a8ci18n
Copy link

a8ci18n commented Jan 31, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17220392

Some locales (Hebrew, Japanese, Spanish) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @DustyReagan for including a screenshot in the description! This is really helpful for our translators.

Copy link
Contributor

@holdercp holdercp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good:
image
image

And I'm seeing the Tracks events:
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants