-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big Sky GF: Add AI Copy to big sky plans step #99127
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~340 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~6133 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~335 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@p-jackson From the way the issue is worded it sounded like these copy should be rendered conditionally, is that the case? |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17220117 Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @vykes-mac for including a screenshot in the description! This is really helpful for our translators. |
@vykes-mac yeah this would be conditional on being in the onboarding flow, and have the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, checking this now, I think these new featured features do need to be conditional.
I don't think it makes sense to display them prominently in the standard non-big-sky flow like this:
I also see they're semibold in the mockup. I'm not sure what the best way to customise this sort of thing on a per-flow basis. Especially the changes to the checkout 🤔
I think simplest thing right now is to add the same string twice, the bold one for the plan features and the not bold one for checkout |
} ), | ||
getDescription: () => i18n.translate( 'Build your site with our AI Website Builder.' ), | ||
}, | ||
[ FEATURE_BIG_SKY_WEBSITE_BUILDER_CHECKOUT ]: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copy on the plans page should be bold, so we create a non bold one for the checkout page, maybe there is a better way to do this?
@@ -31,5 +32,7 @@ export function useGoalsFirstExperiment(): [ boolean, boolean ] { | |||
*/ | |||
const variationName = experimentAssignment?.variationName ?? 'control'; | |||
|
|||
setPlansListExperiment( EXPERIMENT_NAME, variationName ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This depends on this #99133 PR as the experiment name is changed there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will actually go in useBigSkyBeforePlans
, so it depends on #99096
|
||
export function isGoalsFirst(): boolean { | ||
return ( | ||
getPlansListExperiment( 'calypso_signup_onboarding_goals_first_flow_holdout_20241220' ) === |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are only showing the copy to the treatment_cumulative
group. @p-jackson can you confirm this? Also the experiment name when this PR is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮
Technique makes sense! Seems like we're basically showing the new copy if the experiment assignment happens to be be loaded. If it hasn't nothing catastrophic happens, but following the usual flow the test group assignment should have been made by now.
We are only showing the copy to the
treatment_cumulative
group
This is one of the goals-first experiment cohorts. But this copy change shouldn't actually be part of the goals-first experiment. It's for the big sky experiment
getPlansListExperiment
I think there's actually another explat function we can use for this: dangerouslyGetMaybeLoadedExperimentAssignment
It should reach into explat and get the user's current assignment, returning null
if it hasn't been assigned.
I'll make the changes so that we're using the correct experiment. Or maybe even I'll use the feature flag for this PR so I can get it merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see now. getPlansListExperiment
isn't a new thing we've added; it's an existing library function. If this is how previous experiments have been done, it makes sense for us to do it the same way. So I won't switch to dangerouslyGetMaybeLoadedExperimentAssignment
.
@@ -80,6 +81,7 @@ export default function CheckoutMainWrapper( { | |||
const translate = useTranslate(); | |||
const locale = useSelector( getCurrentUserLocale ); | |||
const selectedSiteId = useSelector( getSelectedSiteId ) ?? undefined; | |||
useGoalsFirstExperiment(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this to ensure the experiment assignment is stored in memory and we can retrieve it to render the feature list. But I don't love that it implicitly assigns the user to a cohort if they haven't been assigned yet.
Who knows where checkout-main-wrapper
is being included from, causing an assignment to occur.
I think the hook's internal flow === 'onboarding'
check will be enough to save us though.
…d on plans page should be bold
4635b1d
to
246305e
Compare
if ( new URLSearchParams( location.search ).has( 'big-sky-checkout' ) ) { | ||
return true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vykes-mac I added a query parameter for the checkout screen case, so that the message only appears when the user actually chooses Big Sky
if ( typeof window === 'undefined' ) { | ||
return false; | ||
} | ||
|
||
return Boolean( window.__a8cBigSkyOnboarding ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vykes-mac I discovered that the Global Styles code was doing a hack like this to conditionally show the text
export function isGlobalStylesOnPersonalEnabled(): boolean { |
So I've done something similar 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this approach also, similar to global styles, but I opted for the experiment name approach so I didn't have to pass a parameter to the checkout page, but that works as well.
Translation for this Pull Request has now been finished. |
Closes #99009
Proposed Changes
Unlimited AI Website Builder edits
to big sky plans gridWhy are these changes being made?
Pre-req
setPlansListExperiment( EXPERIMENT_NAME, variationName );
in theuse-goals-first-experiment.ts
file and set the variation totreatment_cumulative
wp-calypso/client/landing/stepper/declarative-flow/helpers/use-goals-first-experiment.ts
Line 35 in 4635b1d
setup/onboarding
goals first flowTesting Instructions
Pre-merge Checklist