Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100 year domain - use "Paid until" label in domains list #99113

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

gius80
Copy link
Contributor

@gius80 gius80 commented Jan 30, 2025

Proposed Changes

This PR updates the label we show in domains table cell EXPIRES\RENEWS ON cell for 100 year domain.

Why are these changes being made?

Expiration date for 100 year domain is different than their registration subscription expiration. So it's better use a different label that indicates the date doesn't refer to domain expiration date.

Testing Instructions

This PR depends on WPCOM PR 171673-ghe-Automattic/wpcom

Apply this PR and verify that in the domains list, 100 year domains show Paid until label next to the expiration date.

Markup on 2025-01-30 at 18:21:43

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gius80 gius80 requested a review from a team January 30, 2025 17:08
@gius80 gius80 self-assigned this Jan 30, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 30, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~33 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
site-overview       +110 B  (+0.0%)      +33 B  (+0.0%)
hosting             +110 B  (+0.0%)      +33 B  (+0.0%)
domains             +110 B  (+0.0%)      +33 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/100-year-domain-expiration-label on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants