Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright: Update documentation, Part 2. #59017

Merged
merged 5 commits into from
Dec 14, 2021

Conversation

worldomonation
Copy link
Contributor

@worldomonation worldomonation commented Dec 9, 2021

Changes proposed in this Pull Request

After the previous round of updates there are some minor tweaks that should be made to the documentation.

Key changes:

  • fill in missing links to pages under Writing Tests section.
  • add step referring to exporting the environment variable, used for secrets decryption.

Testing instructions

Navigate from the top page to ensure the changes are present.

Related to #58610, #58370.

@worldomonation worldomonation requested review from scinos, WunderBart and a team as code owners December 9, 2021 19:48
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 9, 2021
@worldomonation worldomonation self-assigned this Dec 9, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@worldomonation worldomonation added [Status] In Progress and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 9, 2021
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 9, 2021
Copy link
Contributor

@cometgrrl cometgrrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the navigation links appear correct now.

@worldomonation worldomonation merged commit d95785e into trunk Dec 14, 2021
@worldomonation worldomonation deleted the pw/update-documentation-2 branch December 14, 2021 19:35
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Meta] Playwright: Update documentation Write up Playwright code style.
3 participants