-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update eslint packages #58272
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-22446 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~31 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~46 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
c162fb7
to
c21efea
Compare
c21efea
to
5c19cfd
Compare
@@ -33,6 +33,6 @@ | |||
"@babel/core": "^7.16.0", | |||
"@babel/eslint-parser": "^7.16.3", | |||
"@babel/parser": "^7.16.4", | |||
"eslint": ">=7.32.0" | |||
"eslint": ">=8.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I wonder why it's not updating eslint everywhere else in the repo
- I also wonder why we need >=
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a copy/paste from the peerDependency
. Some people like to have an open range for peer dependencies so we don't repeat the errors of react 17, where so many packages declared a peer dep on react@^16
and they took so long to add react@^17
to the mix.
But I don't think we should have those open ranges for devDependencies
or regular dependencies
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the PR for updating eslint
in the rest of the repo: #56894
I have no idea why it open two different PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it didn't consider this to be a major update and then split it out? Possibly because of the version range.
5c19cfd
to
9120e68
Compare
93f28a0
to
6625d67
Compare
c1987a3
to
3656bf8
Compare
3656bf8
to
9cfeffb
Compare
This PR contains the following updates:
>=7.32.0
->>=8.4.1
^2.1.1
->^2.2.0
Release Notes
muenzpraeger/eslint-plugin-inclusive-language
v2.2.0
Compare Source
PR 52
Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by WhiteSource Renovate. View repository job log here.