-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/inline help a11y #43960
Update/inline help a11y #43960
Conversation
yarn test-client client/blocks/inline-help/test
Co-authored-by: Konstantin Obenland <[email protected]>
Co-authored-by: Konstantin Obenland <[email protected]>
Co-authored-by: Konstantin Obenland <[email protected]>
Co-authored-by: Dave Smith <[email protected]>
Co-authored-by: Dave Smith <[email protected]>
It fixes #43511.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~15065 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~3796 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Fixes #43617
After discussing a bit more with @diegohaz, we've put together some clearer direction for how the markup and interactions should work.
Overview
The search input will operate independently of the results. There won't be any arrow key interactions on the results while focused on the search input. Instead, we can use a
role="grid"
on each search results section.This would allow the support search component to take fewer tab stops in the flow and allow fo arrow key interactions on search results.
Markup General Structure
Keyboard interactions
Other Interactions
speak()
to announce state changes on the search, such as:Testing instructions
Fixes #