-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenborading: premium design flow #42377
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~191 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
client/landing/gutenboarding/onboarding-block/design-selector/index.tsx
Outdated
Show resolved
Hide resolved
e5d8766
to
682ba4e
Compare
- Lift up Doyle to 2nd row on 3 column view - Make Doyle premium - Make Bowen regular, but keep it on 2nd row
77324b8
to
ad1695a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty neat. I tested as instructed and reviewed the code and LGTM!
client/landing/gutenboarding/onboarding-block/design-selector/index.tsx
Outdated
Show resolved
Hide resolved
…index.tsx Co-authored-by: Omar Alshaker <[email protected]>
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3652688 Thank you @simison for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Add premium designs flow in Gutenboarding.
Design brief was this:
min-height
in elements to achieve that)TODO:
Add
selected_design_is_premium: true|false
prop to existingcalypso_newsite_step_leave
event alongsideselected_design
prop.Remove premium status for the demo in Vesta design and follow-up with actual designs.
Update A/B test dateNot doing.Changes proposed in this Pull Request
Testing instructions
Test the event
localStorage.debug='calypso:analytics';
in consolecalypso_newsite_step_leave
event withis_selected_design_premium: true
prop.calypso_newsite_step_leave
event withis_selected_design_premium: false
prop.