Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenborading: premium design flow #42377

Merged
merged 17 commits into from
May 22, 2020
Merged

Conversation

simison
Copy link
Member

@simison simison commented May 19, 2020

Add premium designs flow in Gutenboarding.

image

Design brief was this:

screen-capture-on-2020-05-21-at-19-57-53-1

  • Note how title is in the middle, followed by the badge on the right
  • Tooltip opens right-away (couldn't do, there's 700ms delay)
  • Tooltip has space before badge (hence there's additional min-height in elements to achieve that)
  • Tooltip is bottom+centered (couldn't do, tooltip seems to have its own life in this regard)

TODO:

  • Add selected_design_is_premium: true|false prop to existing calypso_newsite_step_leave event alongside selected_design prop.

  • Remove premium status for the demo in Vesta design and follow-up with actual designs.

  • Update A/B test date Not doing.

Changes proposed in this Pull Request

  • Tag one of the designs as "premium"
  • Show premium badge next to design name
  • When the premium design is selected, pre-select "premium" plan

Testing instructions

  • At Gutenboarding (start fresh with http://calypso.localhost:3000/new/?fresh)
  • Confirm that selecting premium design chooses premium plan by default and that picking free design again goes back to free
  • Confirm that picking a paid domain does the same separately from design and that switching either one to free doesn't cancel the other one until both are on free options
  • Confirm premium plan selected when opening plans grid
  • Confirm premium plan in checkout when progressing in the flow

Test the event

  • Set localStorage.debug='calypso:analytics'; in console
  • Pick premium theme and confirm calypso_newsite_step_leave event with is_selected_design_premium: true prop.
  • Pick non-premium theme and confirm calypso_newsite_step_leave event with is_selected_design_premium: false prop.

@simison simison added [Status] In Progress [Goal] New Onboarding previously called Gutenboarding labels May 19, 2020
@matticbot
Copy link
Contributor

matticbot commented May 19, 2020

@matticbot
Copy link
Contributor

matticbot commented May 19, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~191 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding      +1020 B  (+0.1%)     +191 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@simison simison force-pushed the update/gutenboarding-premium-design branch 2 times, most recently from e5d8766 to 682ba4e Compare May 22, 2020 11:36
@simison simison force-pushed the update/gutenboarding-premium-design branch from 77324b8 to ad1695a Compare May 22, 2020 12:52
@simison simison marked this pull request as ready for review May 22, 2020 13:08
@simison simison requested a review from a team as a code owner May 22, 2020 13:08
@simison simison added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels May 22, 2020
Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty neat. I tested as instructed and reviewed the code and LGTM!

@simison simison added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 22, 2020
@simison simison merged commit 6809a01 into master May 22, 2020
@simison simison deleted the update/gutenboarding-premium-design branch May 22, 2020 14:37
@a8ci18n
Copy link

a8ci18n commented May 22, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3652688

Thank you @simison for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented May 28, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] New Onboarding previously called Gutenboarding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants