Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Polish and update timeline block to support alternating on large screens #41474

Merged
merged 15 commits into from
Jul 9, 2020
Merged

Blocks: Polish and update timeline block to support alternating on large screens #41474

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6b1a129
Initial porting work.
jasmussen Apr 22, 2020
d615354
Interim refactor work.
jasmussen Apr 27, 2020
1f4bd42
Polish appender.
jasmussen Apr 27, 2020
406e903
New icon.
jasmussen Apr 27, 2020
1c6535b
Add alternating toggle to Timeline block
Jun 11, 2020
3882a79
Add is-left and is-right class toggles for Timeline items
Jun 12, 2020
48d33d4
Improve alignment controls for Timeline item blocks
Jun 12, 2020
3a0a021
Output left/right on frontend, fix styling, polish buttons.
jasmussen Jun 15, 2020
677cfc3
Polish appender and rename again.
jasmussen Jun 15, 2020
edf323d
Increase specificity.
jasmussen Jun 15, 2020
54678f0
Add is-alternating selector for styles
Jun 22, 2020
4399cc2
Hide alignment buttons on TimelineItem blocks if not alternating, def…
Jun 24, 2020
5a7ad97
Move Alternating control to sidebar
Jun 25, 2020
d399d77
Polish alternating toggle.
jasmussen Jun 29, 2020
240aa1a
Polish alternating toggle
jasmussen Jun 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move Alternating control to sidebar
  • Loading branch information
George Hotelling committed Jul 2, 2020
commit 5a7ad97e15995157d9d0d8f0cdf4b2e923817c09
14 changes: 9 additions & 5 deletions apps/full-site-editing/full-site-editing-plugin/jetpack-timeline/blocks/src/timeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
* External dependencies
*/

import { InnerBlocks, BlockControls } from '@wordpress/block-editor';
import { InnerBlocks, InspectorControls } from '@wordpress/block-editor';
import { registerBlockType, createBlock } from '@wordpress/blocks';
import { ToolbarButton } from '@wordpress/components';
import { ToggleControl } from '@wordpress/components';
import { dispatch } from '@wordpress/data';
import { __ } from '@wordpress/i18n';
import classnames from 'classnames';
Expand Down Expand Up @@ -97,9 +97,13 @@ export function registerTimelineBlock() {

return (
<>
<BlockControls>
<ToolbarButton onClick={ toggleAlternate }>Toggle Alternating</ToolbarButton>
</BlockControls>
<InspectorControls>
<ToggleControl
label={ __( 'Alternate Items', 'full-site-editing' ) }
onChange={ toggleAlternate }
checked={ isAlternating }
/>
</InspectorControls>
<ul className={ classes }>
<InnerBlocks
allowedBlocks={ [ 'jetpack/timeline-item' ] }
Expand Down