Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Site Editing: Fix editor frame after a Gutenberg update #37863

Merged
merged 2 commits into from
Nov 25, 2019

Conversation

Copons
Copy link
Contributor

@Copons Copons commented Nov 22, 2019

Changes proposed in this Pull Request

  • Update a block editor editor CSS class name that was changed in a recent Gutenberg update.

Note: this must be deployed AFTER Gutenberg 7.0.0 lands on WPCOM (see p7DVsv-7Ks-p2).

Testing instructions

  • This must be tested on a FSE site with an updated Gutenberg, or on Horizon.
  • Open the page editor and make sure the FSE frame is visible.
  • Add blocks with different widths (regular, wide, full), and check if they adapt to the frame width instead of the full editor width.
  • Repeat the previous tests in the template part editor.

Fixes #37837

@Copons Copons added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Full Site Editing [Team] Cylon labels Nov 22, 2019
@Copons Copons requested a review from a team November 22, 2019 12:59
@Copons Copons requested a review from a team as a code owner November 22, 2019 12:59
@Copons Copons self-assigned this Nov 22, 2019
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@Addison-Stavlo
Copy link
Contributor

I just tested these changes on Horizon, it looks good and works well.

Side Note: Is there a reason why this frame is important to us for FSE, while it seems to be non-existant for non-FSE editor?

@Copons
Copy link
Contributor Author

Copons commented Nov 22, 2019

I just tested these changes on Horizon, it looks good and works well.

Thanks!

Side Note: Is there a reason why this frame is important to us for FSE, while it seems to be non-existant for non-FSE editor?

There are many reasons! 🙂
One is that, especially for template parts, it's jarring to see them on a huge white canvas, when they are supposed to be only a piece of the page.
I think it's more obvious when you see them side by side:

Vanilla FSE Frame
Screenshot 2019-11-22 at 17 38 42 Screenshot 2019-11-22 at 17 39 09

@Copons Copons merged commit 9291e4b into master Nov 25, 2019
@Copons Copons deleted the fix/37837-fse-editor-frame branch November 25, 2019 11:18
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Full Site Editing [Team] Cylon [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The FSE editor frame disappears with latest Gutenberg version
5 participants