Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction timeline: enabled timestamps rendering for all entries #969

Merged
merged 4 commits into from
Oct 5, 2020
Merged

Transaction timeline: enabled timestamps rendering for all entries #969

merged 4 commits into from
Oct 5, 2020

Conversation

kalessil
Copy link
Contributor

@kalessil kalessil commented Oct 2, 2020 •
edited
Loading

Fixes #791

Changes proposed in this Pull Request

  • Enables timestamps rendering for all entries in the timeline

Testing instructions

  • navigate to "Payments -> Transactions" in WP administration area
  • click on i-icon on the left of any transaction
  • ensure all entries in the Timeline section (including gray-colored) has time displayed on the right side
  • Added changelog entry (or does not apply)
  • Covered with tests (or have a good reason not to test in the description ☝️)

marcinbot
marcinbot approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@marcinbot marcinbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well! :shipit:

@kalessil kalessil merged commit ad11fcd into master Oct 5, 2020
@kalessil kalessil deleted the update/791-enable-transaction-timeline-timestamps-for-all-entries branch October 5, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcinbot marcinbot marcinbot approved these changes

Assignees
No one assigned
Labels
pr: ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a timestamp to all timeline events
2 participants
@kalessil @marcinbot