Prevent plugin initialization if Jetpack 8.1 or earlier is installed #760
Conversation
Due to changes in the autoloader, if Jetpack 8.1 or earlier is installed alongside WCPay, the whole site would crash. The crash would happen in the `\Jetpack\Config` initialization code. I added a quick & dirty check to show an admin notice if Jetpack 8.1 or earlier is installed, and prevent the rest of the plugin from initializing. I didn't want to spend a lot of effort in this so it's not as smart as the main dependency checker (which shows a link to update the dependency, tells you which version of the dependency you have, etc). I just wanted something temporary that's better than the site crashing. Jetpack 8.2 (which is already compatible with WCPay) was released in February 2020. I think we can remove this piece of code in a few months, maybe when that version is 1 year old? Anyway, I left a TODO comment, if someone stumbles upon it in the distant future it can be removed. To test: - Install Jetpack 8.1 without using this WCPay branch. Note that the site crashes. - Install Jetpack 8.2. Everything works fine. - Install Jetpack 8.1 again, now using this WCPay branch. You'll see a notice telling you to upgrade, and you won't see the `[$] Payments` menu at all. - Install Jetpack 8.2, still using this WCPay branch. Everything should work fine. - Disable Jetpack. Everything should still work fine.
|
Hi @DanReyLop! I tested this to see what's going on. Here’s what I tested:
I see this error:
Does that match what you’ve seen? Also, Woocommerce Payments v1.1.0 uses jetpack-autoloader v1.7.0, correct? So the new v2.0 Jetpack autoloader isn't involved in this error. The above error is caused by a limitation in the v1.x Jetpack Autoloader. That autoloader doesn’t know where the latest version of a package is until all of the plugins have loaded. In Jetpack v8.1.1, it appears that Jetpack used the Connection package before all of the plugins had loaded, most importantly before Woocommerce Payments had loaded. Therefore, the autoloader used Jetpack’s version of the Connection package, not the later version installed by Woocommerce Payments. I think your approach preventing plugin initialization is the only way to resolve this. Even when WooCommerce Payments starts using the v2.0 autoloader package, Jetpack v8.1.1 will still load first and load its connection package before WooCommerce Payments is loaded. I hope that makes sense; let me know if anything's unclear! |
Correct, that's what I'm seeing.
Correct. We can't update
That makes sense, thanks for clarifying! I wasn't completely clear about why this was happening so I just "treated the symptom", which is the only thing we can do :) |
woocommerce-payments.php
Outdated
| ?> | ||
| <div class="notice wcpay-notice notice-error"> | ||
| <p><b><?php echo esc_html( __( 'WooCommerce Payments', 'woocommerce-payments' ) ); ?></b></p> | ||
| <p><?php echo esc_html( __( 'The version of Jetpack installed is too old to be used with WooCommerce Payments. Please deactivate or update Jetpack.', 'woocommerce-payments' ) ); ?></p> |
There was a problem hiding this comment.
I think it should probably explicitly mention WooCommerce Payments is disabled too.
| @@ -53,3 +56,32 @@ function wcpay_init() { | |||
|
|
|||
| // Make sure this is run *after* WooCommerce has a chance to initialize its packages (wc-admin, etc). That is run with priority 10. | |||
| add_action( 'plugins_loaded', 'wcpay_init', 11 ); | |||
There was a problem hiding this comment.
Please add a comment saying that if they change the priority here they need to do so in wcpay_check_old_jetpack_version too
|
Tested and works as advertised. Also re-ran the build and it passed all non-e2e tests: https://travis-ci.com/github/Automattic/woocommerce-payments/builds/176175825 ( e2e tests were still running when I submitted this comment) |
|
It seems like e2e tests failed but the reasons seem unrelated. |
Due to changes in the autoloader, if Jetpack 8.1 or earlier is installed alongside WCPay, the whole site would crash. The crash would happen in the
\Jetpack\Configinitialization code.I added a quick & dirty check to show an admin notice if Jetpack 8.1 or earlier is installed, and prevent the rest of the plugin from initializing. I didn't want to spend a lot of effort in this so it's not as smart as the main dependency checker (which shows a link to update the dependency, tells you which version of the dependency you have, etc). I just wanted something temporary that's better than the site crashing.
Jetpack 8.2 (which is already compatible with WCPay) was released in February 2020. I think we can remove this piece of code in a few months, maybe when that version is 1 year old? Anyway, I left a TODO comment, if someone stumbles upon it in the distant future it can be removed.
To test:
[$] Paymentsmenu at all.Fixes #577.