Restore foreground color rules #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested a patch on my sandbox that fixes this …
And it's now working as expected. |
|
Thank you! This is deployed, and I'll work on fixing up Varia, Coutoire, and Alves too. |
This was referenced Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1966 and #1944 made some changes to foreground color rules when a preset background color was selected. This led to existing sites changing appearance, even when custom colors were not active.
This PR restores some of those rules, in order to restore the previous appearance. It also modifies the custom color rules to properly override these changes.
If this looks right, we should apply these same changes to Varia as well as to Coutoire and Alves. I can spin up PRs for those after this one lands.
Screenshot
The following screenshots were taken with the Rivington default homepage.
Before (Default Colors)
After (Default Colors)
Before (Custom Colors)
After (Custom Colors)