-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade @php-wasm and related dependencies to 0.7.20 #154
Conversation
When running these updated dependency changes locally, I encounter the following error when starting or creating a site:
Indeed in the WordPress-Playground CHANGELOG I note this breaking change related to @sejas I can't quite tell if the "Remaining Work" section in WordPress/wordpress-playground#1423 means there is still work needed in WordPress-Playground to resolve the breaking change related to If that's the case, we can hit pause on this PR until those changes have been completed. If not, do you note if there's any further dependency updates needed in Studio to resolve this breaking change? Perhaps we would need to update vendor/wp-now as well? Any further thoughts on the approach are welcome. 🙇 |
It seems we will need to refactor |
That sounds great. Let me know if I can help review. |
@derekblank @sejas I checked it, and it seems that wp-now doesn't use the Should we continue with this PR and plan to switch from using |
I agree. I don't have much context for why wp-now is included as a separate vendored copy, but I imagine it was either to introduce custom code changes to the library, or perhaps to fence the library off from receiving updates to keep Studio development stable. (Lacking this context) It seems like it'd be more efficient to use wp-now directly, either as a node dependency or a git submodule, and keep Studio up-to-date with wp-now changes. Is there anything preventing this? |
@derekblank we decided to fork wp-now, here is more context: https://github.com/Automattic/local-environment/pull/46 |
Closing in favor of #392 |
Related to #119
Proposed Changes
Support for WebP images was added to WordPress-Playground in 0.7.20 packages. Upgrading @php-wasm and related dependencies should allow users to upload WebP files.
Upgrades the following related dependencies to
0.7.20
:@php-wasm/node
@php-wasm/universal
@wp-playground/blueprints
Testing Instructions
(TBD)
TODO
Pre-merge Checklist