Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.24.5 #7739

Merged
merged 12 commits into from
Jan 16, 2025
Merged

Release 4.24.5 #7739

merged 12 commits into from
Jan 16, 2025

Conversation

donnapep
Copy link
Collaborator

@donnapep donnapep commented Jan 15, 2025 •
edited
Loading

Proposed Changes

  • Update $$next-version$$ placeholder.
  • Update change log.
  • Bump version.
  • Update .pot file.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@donnapep donnapep added this to the 4.24.5 milestone Jan 15, 2025
@donnapep donnapep self-assigned this Jan 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited by donnapep
Loading

Please perform the following tests with the built package in a new installation before publishing:

  • Check that the installed version is correct on the Plugins page.
  • Create and publish a course, a module, and a lesson to the course.
  • Enable the learning mode in the course.
  • Log in with a user and complete the course.
  • Visit Students in admin and observe that the user is displayed with the course completed.
  • Disable learning mode in the course.
  • Visit the course again to make sure that it displayed correctly.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@donnapep donnapep requested a review from a team January 16, 2025 14:24
merkushin
merkushin approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@merkushin merkushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@donnapep donnapep merged commit c9a608c into trunk Jan 16, 2025
22 checks passed
@donnapep donnapep deleted the release/4.24.5 branch January 16, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merkushin merkushin merkushin approved these changes

Assignees

@donnapep donnapep

Labels
No Changelog
Projects
None yet
Milestone
4.24.5
Development

Successfully merging this pull request may close these issues.
3 participants
@donnapep @merkushin @m1r0