-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show one generic message in case HPPS functionality is disabled #7372
Conversation
I suppose the failing checks are related to this PR: #7369 |
Could we simplify this:
to something like this:
I think being in development and using "caution" are already implied by "experimental". |
Here is the updated message: The second line ("As this feature is currently experimental, it may not be available yet on some sites.") appears only when the feature is disabled. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #7372 +/- ##
============================================
+ Coverage 50.74% 50.77% +0.02%
+ Complexity 11148 11145 -3
============================================
Files 613 613
Lines 47060 47042 -18
Branches 404 404
============================================
+ Hits 23881 23884 +3
+ Misses 22852 22831 -21
Partials 327 327
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Message looks good to me!
Resolves #7362
Proposed Changes
Testing Instructions
disable_functions
in your php.ini (Like that:disable_functions = set_time_limit, get_resources
)add_filter( 'sensei_feature_flag_experimental_features_ui', '__return_true' );
Pre-Merge Checklist