Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Clips] Add error empty state for App Clip and podcast latest episode fallback #2809

Merged
merged 5 commits into from
Mar 10, 2025

Conversation

danielebogo
Copy link
Contributor

@danielebogo danielebogo commented Mar 6, 2025

📘 Part of: #2549

This PR replaces the Alert with an empty state for when the App Clip can not handle a URL.

Also this PR updates the way we load the URL:

  1. it checks if there's podcast data
  2. if it is we try to load the episode if the data exists
  3. if the data doesn't exist we try to load the latest episode so the user at least play something
  4. if the app clip fails at any moment we show the error empty state and not the alert
Light Dark
RocketSim_Screenshot_iPhone_16_6 1_2025-03-06_17 19 31 RocketSim_Screenshot_iPhone_16_6 1_2025-03-06_17 19 42

To test

• In Xcode Select the App Clip scheme
• Edit the scheme and the appClipInvocationURLString with https://pca.st/hiddenbrain
• Run the App Clip target
• Confirm it plays the latest episode
• Modify the appClipInvocationURLString with https://pca.st/episode/2fd294d4-9c85-4401-b3b2-ea54b81cf54f
• Confirm you see the specific episode
• Modify the appClipInvocationURLString with https://pca.st/aaaaa
• Confirm you see the empty state and the banner shows quickly

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added this to the 7.84 ❄️ milestone Mar 6, 2025
@danielebogo danielebogo requested a review from a team as a code owner March 6, 2025 17:38
@dangermattic
Copy link
Collaborator

dangermattic commented Mar 6, 2025

1 Warning
⚠️ This PR is assigned to the milestone 7.84 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@danielebogo danielebogo linked an issue Mar 6, 2025 that may be closed by this pull request
@danielebogo danielebogo requested a review from dcamozzi March 10, 2025 10:58
@danielebogo danielebogo changed the title [App Clips] Add empty state for App Clip [App Clips] Add error empty state for App Clip and podcast latest episode fallback Mar 10, 2025
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great!
:shipit:

@danielebogo danielebogo merged commit cde1c84 into release/7.84 Mar 10, 2025
4 of 6 checks passed
@danielebogo danielebogo deleted the danieleb/fix/app-clip-empty-state branch March 10, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project: App Clip
3 participants