Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Revert] Dismiss episode detail when archiving #2802

Merged
merged 3 commits into from
Mar 5, 2025
Merged

[Revert] Dismiss episode detail when archiving #2802

merged 3 commits into from
Mar 5, 2025

Conversation

danielebogo
Copy link
Contributor

Revert #2687

This PR revert the last change and re-introduce the dismiss action when archiving an episode

RocketSim_Recording_iPhone_16_6.1_2025-03-04_14.45.13.mp4

To test

  • CI must be 🟢
  • Open an episode detail
  • Tap on archive
  • The view should dismiss

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added this to the 7.84 ❄️ milestone Mar 4, 2025
@danielebogo danielebogo requested a review from a team as a code owner March 4, 2025 14:51
SergioEstevao
SergioEstevao approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@danielebogo danielebogo changed the base branch from release/7.84 to trunk March 5, 2025 17:20
@danielebogo danielebogo modified the milestones: 7.84 ❄️, 7.85 Mar 5, 2025
@danielebogo danielebogo enabled auto-merge March 5, 2025 17:23
@danielebogo danielebogo merged commit 9a03cbe into trunk Mar 5, 2025
4 of 6 checks passed
@danielebogo danielebogo deleted the danieleb/fix/revert-2635 branch March 5, 2025 17:34
@danielebogo danielebogo mentioned this pull request Mar 5, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
[Type] Fix
Projects
None yet
Milestone
7.85
Development

Successfully merging this pull request may close these issues.
2 participants
@danielebogo @SergioEstevao