Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do proper return on analytics opt out when not an APPCLIP #2769

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

SergioEstevao
Copy link
Contributor

| 📘 Part of: # |
|:---:|

Fixes #

Do proper return on analytics opt out when not an APPCLIP

To test

  1. Add a breakpoint on the code changed
  2. Run the regular
  3. Check if returned valued is the one stored in settings

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the [Type] Bug Used for issues where something is not functioning as intended. label Feb 21, 2025
@SergioEstevao SergioEstevao added this to the 7.82.1 milestone Feb 21, 2025
@SergioEstevao SergioEstevao requested a review from a team as a code owner February 21, 2025 11:45
@SergioEstevao SergioEstevao requested review from bjtitus and leandroalonso and removed request for a team February 21, 2025 11:45
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 7.82.1. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao requested review from joshheald and removed request for bjtitus February 21, 2025 11:57
@joshheald joshheald self-assigned this Feb 21, 2025
Copy link

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the APPCLIP branch being called when I run the app clip, so I'm not sure when it's checked in that case. It's because the whole function isn't called, not that it's going in to the wrong branch.

The standard build of the app app does call the analyticsOptOut function and returns the appropriate value.

Copy link
Member

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to be done in this PR but it would be good if we can add an unit test to prevent that from ever happening again,

@leandroalonso leandroalonso merged commit e8288c5 into release/7.82.1 Feb 21, 2025
4 of 6 checks passed
@leandroalonso leandroalonso deleted the fix/analytics_optout branch February 21, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants