-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sync hash table to control episode download cache #2748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left few comments. Can you add few tests to make sure it works?
podcasts.xcodeproj/xcshareddata/xcschemes/Pocket Casts Watch App.xcscheme
Outdated
Show resolved
Hide resolved
@SergioEstevao can you also update the Changelog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works really good!
|
||
@testable import podcasts | ||
|
||
final class ThreadSafeDictionaryTests: XCTestCase { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
# Conflicts: # Modules/Utils/Sources/PocketCastsUtils/Feature Flags/FeatureFlag.swift
| 📘 Part of: # |
|:---:|
Fixes #
Adds a synced hash table that is controlled by a synchronous queue and then use this to controls access the episode downloads queue.
To test
Checklist
CHANGELOG.md
if necessary.