Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slow loading of bookmarks #2699

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Fix slow loading of bookmarks #2699

merged 1 commit into from
Jan 27, 2025

Conversation

SergioEstevao
Copy link
Contributor

| 📘 Part of: # |
|:---:|

Fixes #

This update ensure that bookmark episodes that already cached in the database are not loaded again over the wire.

To test

Setup

  • Open the web app, and go to a new podcast and open an episode you never played before
  • Create some bookmarks for it, around 25
  • Now go to the mobile app
  1. Start the app
  2. Open the same episode where you created the bookmarks
  3. Play the episode
  4. Open the full screen player
  5. Tap on Bookmarks tab
  6. Scroll around and see if performance is ok.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added this to the 7.81 ❄️ milestone Jan 24, 2025
@SergioEstevao SergioEstevao requested a review from a team as a code owner January 24, 2025 18:46
@SergioEstevao SergioEstevao requested review from bjtitus and danielebogo and removed request for a team and bjtitus January 24, 2025 18:46
@SergioEstevao SergioEstevao changed the base branch from trunk to release/7.81 January 24, 2025 18:46
danielebogo
danielebogo approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Tested as described and it works with no issues

@SergioEstevao SergioEstevao merged commit a61aa82 into release/7.81 Jan 27, 2025
7 of 10 checks passed
@SergioEstevao SergioEstevao deleted the fix/slow_loading_of_bookmarks branch January 27, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielebogo danielebogo danielebogo approved these changes

Assignees
No one assigned
Labels
[Project] Bookmarks [Type] Fix
Projects
None yet
Milestone
7.81
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioEstevao @danielebogo @pachlava