Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the option to share bookmarks for user files. #2661

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

SergioEstevao
Copy link
Contributor

| 📘 Part of: # |
|:---:|

Fixes #

This PR removes the option to share bookmarks that are for user files. Those files are private to the user so it does not make sense to share a link to file other users cannot open.

To test

  1. Start the app
  2. Open the Profile tab
  3. Tap on Files
  4. Tap on one of the files
  5. Tap on bookmark
  6. Select one of the bookmarks
  7. Check that no share option is show

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added this to the 7.81 ❄️ milestone Jan 20, 2025
@SergioEstevao SergioEstevao requested a review from a team as a code owner January 20, 2025 13:54
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team January 20, 2025 13:54
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 20, 2025

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao merged commit f42b409 into release/7.81 Jan 20, 2025
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the remove_share_bookmarks_of_files branch January 20, 2025 15:56
@pachlava pachlava added the [Type] Enhancement Improve an existing feature. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] Bookmarks [Type] Enhancement Improve an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants