Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CarPlay: only cache the episode image if it exists #2610

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

leandroalonso
Copy link
Member

A user contacted us about some episode images not appearing at all.

I was able to reproduce the issue with the podcasts they provided:

This PR changes how we cache images so we don't cache the "default" image.

To test

  1. Add some of the podcasts to your account
  2. Open the CarPlay simulator
  3. Go to Filters > New Releases
  4. Check that the images appear correctly

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@leandroalonso leandroalonso added [Type] Bug Used for issues where something is not functioning as intended. [Area] CarPlay CarPlay related issues labels Jan 6, 2025
@leandroalonso leandroalonso added this to the 7.80 ❄️ milestone Jan 6, 2025
@leandroalonso leandroalonso requested a review from a team as a code owner January 6, 2025 16:59
@leandroalonso leandroalonso requested review from SergioEstevao and removed request for a team January 6, 2025 16:59
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 7.80 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!
:shipit:

@leandroalonso leandroalonso merged commit 01a93db into release/7.80 Jan 7, 2025
4 of 6 checks passed
@leandroalonso leandroalonso deleted the fix/carplay-episode-image-issue branch January 7, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] CarPlay CarPlay related issues [Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants