Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Touch zone on close search results #2494

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

SergioEstevao
Copy link
Contributor

| 📘 Part of: # |
|:---:|

Fixes #

This PR just increases the touch zone are for the close button on the search results for discovery

Before After
simulator_screenshot_74ED7DAD-4242-4EF8-9AFC-2832790E1FD6 simulator_screenshot_2FF27734-C580-4B44-9C1F-10A2522A55C5

To test

  1. Start the app on the iPad
  2. Go to Discovery Tab
  3. Tap on Search
  4. Search for anything
  5. Tap on a result
  6. Go back
  7. Tap on the search bar again
  8. You should see a list of previous searches and result tapped
  9. Tap around the close button, near to it but not necessary in the center of the x image.
  10. Check if the close button removes the entry

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

Frame sizes set on the button are ignored by it, only the label content size matters for the touch area
@SergioEstevao SergioEstevao changed the base branch from trunk to release/7.78 November 29, 2024 12:25
@SergioEstevao SergioEstevao marked this pull request as ready for review November 29, 2024 12:25
@SergioEstevao SergioEstevao requested a review from a team as a code owner November 29, 2024 12:25
@SergioEstevao SergioEstevao requested review from bjtitus and removed request for a team November 29, 2024 12:25
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 29, 2024

1 Warning
⚠️ This PR is assigned to the milestone 7.78. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao added [Type] Bug Used for issues where something is not functioning as intended. iPad iPad related issues labels Nov 29, 2024
@SergioEstevao SergioEstevao added this to the 7.78 milestone Nov 29, 2024
Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Checked on iPad and iPhone

@SergioEstevao SergioEstevao merged commit 880f9a3 into release/7.78 Dec 2, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the fix/touch_zone_on_close_search_results branch December 2, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iPad iPad related issues [Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants