Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shares on radioactivity #2485

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Nov 27, 2024

| 📘 Part of: # |
|:---:|

Fixes #2411

This updates the recently added share interactions to send notifications to proper disable/enable the radioactivity layer when showing system share menus

To test

  1. Start the app using a iPhone (simulator or real device)
  2. Enable the radioactivity theme ( you need to have a subscription)

Share on referrals

  1. Go Profile
  2. Tap on the gift icon on the left
  3. Tap on Share Guest Pass
  4. Check that you can interact with the share screen and radioactivity is disabled
  5. Finish the sharing
  6. Check if radioactivity is back on

Share on Eoy 2024

  1. Go Profile
  2. Tap on the EOY banner
  3. Advance story until you see the share button
  4. Tap on the share button
  5. Check that you can interact with the share screen and radioactivity is disabled
  6. Finish the sharing
  7. Check if radioactivity is back on

Share on episodes

  1. Start playing an episode
  2. Open the full screen player
  3. Tap Share on the actions ( it may be hidden in the options)
  4. Tap on Share again
  5. Check that you can interact with the share screen and radioactivity is disabled
  6. Finish the sharing
  7. Check if radioactivity is back on

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added [Type] Bug Used for issues where something is not functioning as intended. Themes labels Nov 27, 2024
@SergioEstevao SergioEstevao added this to the 7.78 milestone Nov 27, 2024
@SergioEstevao SergioEstevao requested a review from a team as a code owner November 27, 2024 11:04
@SergioEstevao SergioEstevao requested review from bjtitus and removed request for a team November 27, 2024 11:04
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 7.78. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verified Playback sharing
✅ Verified sharing Episode and Podcast from Now Playing and lists
✅ Verified Referrals sharing

@SergioEstevao SergioEstevao merged commit 46b8d09 into release/7.78 Nov 27, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the fix/2411_fix_shares_on_radioactivity branch November 27, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Themes [Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants