Feature: Episode rich text description #2480
Conversation
SergioEstevao
added
the
[Type] Feature
SergioEstevao
changed the title
|
Version |
SergioEstevao
requested review from
danielebogo
and removed request for
a team
There was a problem hiding this comment.
| New | Old |
|---|---|
 |
 |
@SergioEstevao I as able to test this in Staging and I see the font size is different. The new attributed string uses a bigger one. Also not sure about redirecting the users out when tapping on the URL. Wdyt?
|
|
||
| @objc private func labelTapped(gesture: UITapGestureRecognizer) { | ||
| if let url = gesture.didTapLinkInLabel(label: self) { | ||
| UIApplication.shared.open(url) |
There was a problem hiding this comment.
Should we open this externally or internally?
There was a problem hiding this comment.
I followed the same pattern that we have on the page. If you scroll a bit down you will see a section with the podcast url and if you tap on it you are taken to the external browser
|
@danielebogo just adjusted the font size and commented about the URL opening, can you review it again? |
There was a problem hiding this comment.
Hey @SergioEstevao sorry to be super picky but the 1.2em looks smaller than the other one.
I made some test and the closest size I can get with the em is 1.34
| Original | 1.2em |
|---|---|
 |
 |
| Original | 1.34em |
|---|---|
|
 |
Would be great to have feedback from @david-gonzalez-a8c and @dcamozzi
| 📘 Part of: #2479 |
|:---:|
Fixes #
This PR adds support for rich html description for podcasts
To test
usePodcastHTMLDescriptionFF enabled.\nfor<br>Checklist
CHANGELOG.mdif necessary.