-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Episode IDs from the sync task response instead of our local ones #2448
Conversation
Will this help fix my issue Automattic/pocket-casts-android#628? |
@CookieyedCodes I doubt it. How many subscriptions do you have? This would mostly affect large subscription counts where synced episodes routinely exceed 2000. |
I have 2111 feeds 😅, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works!
@bjtitus QQ, do we want this in 7.78 or 7.77?
I initially targeted 7.77 but thought:
But it is flagged, so I'm open to either. |
@bjtitus I'm ok with 7.78 |
# Conflicts: # Modules/Utils/Sources/PocketCastsUtils/Feature Flags/FeatureFlag.swift
Uses the UDIDs of the episodes from the sync response instead of re-querying for the unsynced episodes. This fixes an issue where users with 2000+ episodes in a background sync could send the same episodes during background sync repeatedly.
useSyncResponseEpisodeIDs
feature flag in case we need to disableuuid
instead of the localid
processServerData
to use theseuuids
when handling the server responseUnit Tests
To test
Checklist
CHANGELOG.md
if necessary.