Watch sync improvements #2425
Merged
Watch sync improvements #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioEstevao
requested review from
danielebogo
and removed request for
a team
bjtitus
reviewed
Nov 14, 2024
| } | ||
|
|
||
| let ids = episodes.map({"\($0.id)"}) | ||
| try db.executeUpdate("UPDATE \(DataManager.episodeTableName) SET playingStatusModified = 0, playedUpToModified = 0, durationModified = 0, keepEpisodeModified = 0, archivedModified = 0 WHERE id IN (\(ids.joined(separator: ",")))", values: nil) |
There was a problem hiding this comment.
Should we feature flag this change? I know we've had performance issues with filters when doing queries with long lists so I don't know if that might be an issue here. Maybe less likely because those were issues on the main thread.
There was a problem hiding this comment.
Done here: c62407f
danielebogo
requested changes
Nov 15, 2024
| @@ -728,16 +728,15 @@ class EpisodeDataManager { | |||
| } | |||
|
|
|||
| func markAllSynced(episodes: [Episode], dbQueue: FMDatabaseQueue) { | |||
| if episodes.count == 0 { return } | |||
| guard !episodes.isEmpty else { | |||
There was a problem hiding this comment.
Maybe if episodes.isEmpty is more clear than double negative
There was a problem hiding this comment.
Done here: 4f456c8
| } | ||
|
|
||
| let ids = episodes.map({"\($0.id)"}) | ||
| try db.executeUpdate("UPDATE \(DataManager.episodeTableName) SET playingStatusModified = 0, playedUpToModified = 0, durationModified = 0, keepEpisodeModified = 0, archivedModified = 0 WHERE id IN (\(ids.joined(separator: ",")))", values: nil) |
|
@danielebogo and @bjtitus ready for another look |
# Conflicts: # Modules/Utils/Sources/PocketCastsUtils/Feature Flags/FeatureFlag.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
| 📘 Part of: # |
|:---:|
Fixes #
Optimize sync process to be faster and reduce the maximum number of episodes synced on a partial refresh.
To test
Checklist
CHANGELOG.mdif necessary.