Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single icon for folders upsell #2362

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

SergioEstevao
Copy link
Contributor

| 📘 Part of: # |
|:---:|

Fixes #

This PR removes the locked folders icon and uses an icon with the plus instead.

To test

Free user

  1. Open the app as a free user.
  2. Go to the podcasts screen.
  3. You should see a folders icon with a plus.
  4. Tap on the icon.
  5. An upsell flow should start.
  6. Go back and open any podcast.
  7. You should see a folder icon with a plus.
  8. Tap on the icon.
  9. An upsell flow should start.

Subscribed user

  1. Open the app as a subscribed user.
  2. Go to the podcasts screen.
  3. You should see a folders icon with a plus.
  4. Tap on the icon.
  5. Folder creation flow should start.
  6. Go back and open any podcast.
  7. You should see a folder icon if the podcast does not belong to a folder or folder with checkmark if belongs to a folder
  8. Tap on the icon.
  9. An folder selection flow should start.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added [Type] Enhancement Improve an existing feature. folders Issues related to folders labels Oct 30, 2024
@SergioEstevao SergioEstevao added this to the 7.77 milestone Oct 30, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao marked this pull request as ready for review October 30, 2024 11:45
@SergioEstevao SergioEstevao requested a review from a team as a code owner October 30, 2024 11:45
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team October 30, 2024 11:45
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SergioEstevao ! It works as expected!

@SergioEstevao SergioEstevao merged commit e849af5 into trunk Oct 30, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the sergioestevao/add_folder_icon_for_free_users branch October 30, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
folders Issues related to folders [Type] Enhancement Improve an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants