Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Downloading of Episode: Add logic for auto downloads limits #2318

Merged

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Oct 22, 2024

| 📘 Part of: #2284 |
|:---:|

Fixes #

1 2 3 4
Simulator Screenshot - iPhone 16 Pro - 2024-10-22 at 14 44 05 Simulator Screenshot - iPhone 16 Pro - 2024-10-22 at 14 44 51 Simulator Screenshot - iPhone 16 Pro - 2024-10-23 at 14 21 12 Simulator Screenshot - iPhone 16 Pro - 2024-10-23 at 14 21 03

This PR adds the necessary logic to implement auto-downloads of episodes when subscribing following the set limits of auto-downloads.

To test

Setup

  1. Delete the app of a device
  2. Start the app
  3. Ensure that you have the FF autoDownloadOnSubscribe enabled
  4. Go to Profile -> Settings -> AutoDownload
  5. Check that you have by default Auto-Download enabled ( this is for new installs of the app)
  6. Check that the default limit for auto-downloads is two episodes

Subscribe on Episode

  1. Go to discover
  2. Open a podcast there
  3. Press the subscribe button
  4. Check that you see the download of the latest x amount of episodes you have set on Auto-Downloads limits
  5. Play the episodes

Subscribe on Discover directly

  1. Go to discover
  2. Scroll around
  3. On the trending list tap directly on +
  4. Open the podcast and see if downloads are triggered
  5. Scroll more on discover and find a podcast with an image and a plus button
  6. Tap on plus button
  7. Check that the downloads are triggered

Disable auto-download setting

  1. Disable auto-download settings on Settings
  2. Repeat the subscriptions above and see that no auto-downloads are triggered.

Disable the FF for autoDownloadOnSubscribe

  1. Check that no downloads are triggered on subscribe of podcasts
  2. Note that there was na exception on the old code that if all your podcasts are on auto-download a new subscription will also be part of auto-downloads.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@dangermattic
Copy link
Collaborator

dangermattic commented Oct 22, 2024

1 Warning
⚠️ This PR is assigned to the milestone 7.76. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao marked this pull request as ready for review October 22, 2024 17:58
@SergioEstevao SergioEstevao requested a review from a team as a code owner October 22, 2024 17:58
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team October 22, 2024 17:58
@SergioEstevao SergioEstevao marked this pull request as draft October 23, 2024 13:04
@SergioEstevao SergioEstevao marked this pull request as ready for review October 23, 2024 13:21
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all scenarios and it's working well ✅
Also restested the scenario 1 after the last commit and it's working correctly

@SergioEstevao SergioEstevao merged commit 7430342 into trunk Oct 23, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the autodownloading/add_logic_for_auto_downloads_limits branch October 23, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants