Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sentry] [NSConcreteFileHandle writeData:]: No space left on device #2275

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

danielebogo
Copy link
Contributor

@danielebogo danielebogo commented Oct 15, 2024

Fixes 5942010655-sentry

Attempt to fix the crash if the device run out of disk space. It replaces the write deprecated function using the latest one which throws an exception if the device run out of space.

To test

  • CI should be 🟢
  • Run the app to write some logs
  • Check if the file log works as expected

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added the [Type] Bug Used for issues where something is not functioning as intended. label Oct 15, 2024
@danielebogo danielebogo added this to the 7.75 ❄️ milestone Oct 15, 2024
@danielebogo danielebogo requested a review from bjtitus October 15, 2024 14:05
@danielebogo danielebogo requested a review from a team as a code owner October 15, 2024 14:05
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 15, 2024

1 Warning
⚠️ This PR is assigned to the milestone 7.75 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@danielebogo danielebogo removed the request for review from a team October 15, 2024 14:51
Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

File log looked good in testing.

@danielebogo danielebogo merged commit 74ef33a into release/7.75 Oct 16, 2024
4 of 6 checks passed
@danielebogo danielebogo deleted the danieleb/issues/writing-crash-no-space branch October 16, 2024 14:50
Copy link

sentry-io bot commented Oct 22, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NSFileHandleOperationException: *** -[NSConcreteFileHandle writeData:]: No space left on device LogFileWriter.write View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants