Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing type #2241

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Add missing type #2241

merged 3 commits into from
Oct 8, 2024

Conversation

danielebogo
Copy link
Contributor

@danielebogo danielebogo commented Oct 8, 2024 •
edited
Loading

This PR adds the audio/m4a to our FileTypeUtil.

To test

  • CI must be 🍏
  • Download this episode
  • Make sure it plays

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added the [Type] Bug Used for issues where something is not functioning as intended. label Oct 8, 2024
@danielebogo danielebogo added this to the 7.74 ❄️ milestone Oct 8, 2024
@danielebogo danielebogo requested a review from a team as a code owner October 8, 2024 09:10
@danielebogo danielebogo requested review from bjtitus and removed request for a team October 8, 2024 09:10
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 8, 2024 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 7.74 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

SergioEstevao
SergioEstevao approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@danielebogo danielebogo merged commit e23eba7 into release/7.74 Oct 8, 2024
4 of 6 checks passed
@danielebogo danielebogo deleted the danieleb/add-missing-type branch October 8, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@bjtitus bjtitus Awaiting requested review from bjtitus bjtitus was automatically assigned from Automattic/pocket-casts-ios

Assignees
No one assigned
Labels
[Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Milestone
7.74
Development

Successfully merging this pull request may close these issues.
3 participants
@danielebogo @dangermattic @SergioEstevao